Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix input field popover #819

Merged
merged 5 commits into from
Nov 17, 2023
Merged

chore: fix input field popover #819

merged 5 commits into from
Nov 17, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Nov 15, 2023

Overview

the pop over when chosen the time zone looks weird, this pr is to fix that

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 0622ee0
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6557179becd9a500086c72a6
😎 Deploy Preview https://deploy-preview-819--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #819 (0622ee0) into main (a38df11) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   25.70%   25.69%   -0.01%     
==========================================
  Files        1636     1636              
  Lines      180097   180099       +2     
  Branches     3911     3911              
==========================================
- Hits        46287    46285       -2     
- Misses     132721   132725       +4     
  Partials     1089     1089              
Flag Coverage Δ
web 23.92% <0.00%> (-0.01%) ⬇️
web-beta 23.92% <0.00%> (-0.01%) ⬇️
web-classic 23.92% <0.00%> (-0.01%) ⬇️
web-utils 23.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...b/src/beta/components/fields/SelectField/index.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@nina992 nina992 merged commit d42279c into main Nov 17, 2023
15 of 16 checks passed
@nina992 nina992 deleted the chore/fix-time-input branch November 17, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants