Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix overriding layer structure #818

Merged
merged 3 commits into from
Nov 16, 2023
Merged

chore(web): fix overriding layer structure #818

merged 3 commits into from
Nov 16, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Nov 15, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 requested a review from KaWaite November 15, 2023 08:12
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 57104bf
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/655491f8f0f4370008bde491
😎 Deploy Preview https://deploy-preview-818--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #818 (57104bf) into main (4ad7bbe) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   25.72%   25.72%           
=======================================
  Files        1635     1635           
  Lines      179860   179864    +4     
  Branches     3912     3913    +1     
=======================================
+ Hits        46273    46275    +2     
- Misses     132498   132500    +2     
  Partials     1089     1089           
Flag Coverage Δ
web 23.95% <100.00%> (+<0.01%) ⬆️
web-beta 23.95% <100.00%> (+<0.01%) ⬆️
web-classic 23.95% <100.00%> (+<0.01%) ⬆️
web-utils 23.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/Map/Layers/hooks.ts 83.18% <100.00%> (+0.03%) ⬆️
...src/beta/lib/core/mantle/evaluator/simple/index.ts 77.52% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

@keiya01 keiya01 merged commit 034e984 into main Nov 16, 2023
15 of 16 checks passed
@keiya01 keiya01 deleted the fix/override branch November 16, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants