Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): move doubleClick with debounce to utils #811

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Nov 14, 2023

Overview

This PR moves the logic used for handle doubleClicks in layerStyleCard and layerItem to a general hook called useDoubleClick in utils.

@pyshx pyshx requested a review from KaWaite as a code owner November 14, 2023 07:54
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 71ced25
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/655327a2820d72000879953e
😎 Deploy Preview https://deploy-preview-811--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #811 (71ced25) into main (770edb9) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   25.71%   25.72%           
=======================================
  Files        1635     1635           
  Lines      179907   179874   -33     
  Branches     3912     3912           
=======================================
  Hits        46268    46268           
+ Misses     132550   132517   -33     
  Partials     1089     1089           
Flag Coverage Δ
web 23.94% <0.00%> (+<0.01%) ⬆️
web-beta 23.94% <0.00%> (+<0.01%) ⬆️
web-classic 23.94% <0.00%> (+<0.01%) ⬆️
web-utils 23.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...res/Editor/tabs/map/LeftPanel/Layers/LayerItem.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/map/BottomPanel/LayerStyleCard.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@pyshx pyshx merged commit 80b65fa into main Nov 14, 2023
16 of 17 checks passed
@pyshx pyshx deleted the chore/move-doubleClick branch November 14, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants