Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): modify zoom level field #808

Merged
merged 18 commits into from
Nov 28, 2023
Merged

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Nov 13, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 066b330
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6565888647978c0007924653
😎 Deploy Preview https://deploy-preview-808--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #808 (066b330) into main (ebf99c0) will decrease coverage by 0.03%.
The diff coverage is 0.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   25.66%   25.64%   -0.03%     
==========================================
  Files        1638     1640       +2     
  Lines      180326   180458     +132     
  Branches     3913     3915       +2     
==========================================
- Hits        46289    46284       -5     
- Misses     132948   133085     +137     
  Partials     1089     1089              
Flag Coverage Δ
web 23.86% <0.70%> (-0.03%) ⬇️
web-beta 23.86% <0.70%> (-0.03%) ⬇️
web-classic 23.86% <0.70%> (-0.03%) ⬇️
web-utils 23.86% <0.70%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Editor/Settings/index.tsx 0.00% <ø> (ø)
web/src/beta/lib/core/Map/types/index.ts 0.00% <0.00%> (ø)
.../src/beta/lib/core/engines/Cesium/core/Imagery.tsx 78.70% <25.00%> (-0.14%) ⬇️
...components/fields/Property/PropertyField/index.tsx 0.00% <0.00%> (ø)
...eb/src/beta/components/fields/RangeField/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/RangeSlider/index.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@lavalse
Copy link
Member

lavalse commented Nov 22, 2023

image
If possible, for UI side, the default range should be full ( 0~30 )

@KaWaite KaWaite merged commit 1b79cfb into main Nov 28, 2023
15 of 16 checks passed
@KaWaite KaWaite deleted the chore/modify-zoomLevel-field branch November 28, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants