Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Slider fixes #795

Merged
merged 13 commits into from
Nov 8, 2023
Merged

chore(web): Slider fixes #795

merged 13 commits into from
Nov 8, 2023

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Nov 7, 2023

Overview

Slider Fixes

What I've done

  • Slider value only updates when the user stops dragging the slider

What I haven't done

  • Couldn't re-create the bug where the NULL value is sent
  • the above might have existed because initially the onChange triggered on dragging, now it only triggered after it has stopped. I tried and it works okay now so probably no need to fix now

How I tested

  • Storybook and UI

Which point I want you to review particularly

  • Do I need to a NULL check in the code?

Memo

  • NA

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit e324dc8
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654af10d0ba6ba0008ee35ee
😎 Deploy Preview https://deploy-preview-795--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #795 (e324dc8) into main (6d53607) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   25.96%   25.96%   -0.01%     
==========================================
  Files        1630     1630              
  Lines      178185   178194       +9     
  Branches     3914     3913       -1     
==========================================
- Hits        46271    46270       -1     
- Misses     130825   130835      +10     
  Partials     1089     1089              
Flag Coverage Δ
web 24.22% <0.00%> (-0.01%) ⬇️
web-beta 24.22% <0.00%> (-0.01%) ⬇️
web-classic 24.22% <0.00%> (-0.01%) ⬇️
web-utils 24.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...b/src/beta/components/fields/SliderField/index.tsx 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@jashanbhullar jashanbhullar merged commit 801396d into main Nov 8, 2023
15 of 16 checks passed
@jashanbhullar jashanbhullar deleted the chore(web)/slider-fixes branch November 8, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants