Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): misc bug fixes improvements #793

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 7, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit eea39cb
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6549ba39d95bfa0008e35e7c
😎 Deploy Preview https://deploy-preview-793--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KaWaite KaWaite changed the title chore(web): misc bug fixes imrpovements chore(web): misc bug fixes improvements Nov 7, 2023
@github-actions github-actions bot added the web label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #793 (eea39cb) into main (be18c61) will increase coverage by 0.00%.
The diff coverage is 20.23%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage   25.97%   25.97%           
=======================================
  Files        1630     1630           
  Lines      178084   178128   +44     
  Branches     3912     3914    +2     
=======================================
+ Hits        46252    46266   +14     
- Misses     130743   130773   +30     
  Partials     1089     1089           
Flag Coverage Δ
web 24.23% <20.23%> (+<0.01%) ⬆️
web-beta 24.23% <20.23%> (+<0.01%) ⬆️
web-classic 24.23% <20.23%> (+<0.01%) ⬆️
web-utils 24.23% <20.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/StoryPanel/constants.ts 100.00% <100.00%> (ø)
web/src/services/state/index.ts 100.00% <100.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useLayerStyles.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/utils.ts 0.00% <0.00%> (ø)
...rc/beta/components/SidePanelSectionField/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useScene.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@KaWaite KaWaite merged commit b099092 into main Nov 7, 2023
18 checks passed
@KaWaite KaWaite deleted the fallback-gap-padding branch November 7, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant