Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): 3dtile feature select support in UI #792

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 6, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit c825a8f
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6548fe473425cb000817b1fa
😎 Deploy Preview https://deploy-preview-792--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 6, 2023
@KaWaite KaWaite marked this pull request as ready for review November 6, 2023 14:55
@KaWaite KaWaite requested a review from keiya01 as a code owner November 6, 2023 14:55
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #792 (c825a8f) into main (a875a2d) will increase coverage by 0.00%.
The diff coverage is 15.38%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   25.97%   25.97%           
=======================================
  Files        1630     1630           
  Lines      178068   178084   +16     
  Branches     3913     3914    +1     
=======================================
+ Hits        46251    46258    +7     
- Misses     130728   130737    +9     
  Partials     1089     1089           
Flag Coverage Δ
web 24.23% <15.38%> (+<0.01%) ⬆️
web-beta 24.23% <15.38%> (+<0.01%) ⬆️
web-classic 24.23% <15.38%> (+<0.01%) ⬆️
web-utils 24.23% <15.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/engines/Cesium/index.tsx 0.00% <ø> (ø)
web/src/services/state/index.ts 100.00% <100.00%> (ø)
web/src/beta/lib/core/Visualizer/index.tsx 0.00% <0.00%> (ø)
...tabs/map/RightPanel/LayerInspector/FeatureData.tsx 0.00% <0.00%> (ø)
...ditor/tabs/map/RightPanel/LayerInspector/index.tsx 0.00% <0.00%> (ø)
...r/tabs/map/RightPanel/LayerInspector/LayerData.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/Visualizer/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/hooks.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@KaWaite KaWaite merged commit be18c61 into main Nov 6, 2023
16 of 17 checks passed
@KaWaite KaWaite deleted the 3dtile-feature-support branch November 6, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant