Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): add position, bgColor & title to story & page json respectively for published story #787

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Nov 3, 2023

Overview

This PR adds support for panelPosition ,bgColor and title fields in storyJSON and pageJSON respectively to have access to them in published stories.

@github-actions github-actions bot added the server label Nov 3, 2023
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit a49c3da
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6548e9c6cda84c000811445e

@pyshx pyshx changed the title chore(server): add position & title to story & page json respectively for published story chore(server): add position, bgColor & title to story & page json respectively for published story Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #787 (a49c3da) into main (c158b69) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   25.97%   25.97%   -0.01%     
==========================================
  Files        1630     1630              
  Lines      178057   178060       +3     
  Branches     3913     3913              
==========================================
  Hits        46247    46247              
- Misses     130721   130724       +3     
  Partials     1089     1089              
Flag Coverage Δ
server 33.36% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/pkg/scene/builder/story.go 0.00% <0.00%> (ø)
server/pkg/storytelling/story.go 59.32% <0.00%> (-1.03%) ⬇️

@pyshx pyshx merged commit cea0d7b into main Nov 6, 2023
18 of 19 checks passed
@pyshx pyshx deleted the chore/add-position-title-to-page-block-json branch November 6, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant