Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix delete last page doesn't refresh the right panel #771

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Oct 29, 2023

Overview

This pr is to fix the issue of page delete in story panel as , when the user delete last page in left story panel , the right panel should be refreshed accordingly , but that wasn't happened.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner October 29, 2023 13:01
@github-actions github-actions bot added the web label Oct 29, 2023
@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 9c7c1d0
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/653e57a0f39cf70008fd0a22
😎 Deploy Preview https://deploy-preview-771--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ce3a60e
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/653f4a0a57890d00085b0042
😎 Deploy Preview https://deploy-preview-771--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #771 (ce3a60e) into main (9cab761) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
+ Coverage   26.25%   26.27%   +0.01%     
==========================================
  Files        1610     1609       -1     
  Lines      176136   176045      -91     
  Branches     3898     3900       +2     
==========================================
+ Hits        46253    46256       +3     
+ Misses     128794   128700      -94     
  Partials     1089     1089              
Flag Coverage Δ
web 24.55% <0.00%> (+<0.01%) ⬆️
web-beta 24.55% <0.00%> (+<0.01%) ⬆️
web-classic 24.55% <0.00%> (+<0.01%) ⬆️
web-utils 24.55% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ta/features/Editor/tabs/story/RightPanel/index.tsx 0.00% <ø> (ø)
web/src/beta/features/Editor/useStorytelling.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Settings/hooks.ts 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

@nina992 nina992 merged commit 66c6f91 into main Oct 30, 2023
16 checks passed
@nina992 nina992 deleted the chore/fix-delete-last-page branch October 30, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants