Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): add array and timeline valuetype to property #770

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Oct 27, 2023

Overview

This PR adds support for array and timeline valueType in property to the server.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 1d5b024
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/653bb55c987d7c0008954c3a

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #770 (1d5b024) into main (da57ac4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   26.26%   26.24%   -0.02%     
==========================================
  Files        1609     1610       +1     
  Lines      176025   176098      +73     
  Branches     3900     3900              
==========================================
- Hits        46232    46218      -14     
- Misses     128704   128791      +87     
  Partials     1089     1089              
Flag Coverage Δ
server 33.39% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rnal/adapter/gql/resolver_mutation_storytelling.go 0.00% <ø> (ø)
server/internal/infrastructure/mongo/nlslayer.go 0.00% <ø> (ø)
server/internal/usecase/interactor/storytelling.go 0.00% <ø> (ø)
server/pkg/property/value.go 37.34% <ø> (ø)
server/pkg/property/value_spacing.go 16.94% <ø> (ø)
server/pkg/value/type.go 87.09% <ø> (ø)
.../internal/adapter/gql/gqlmodel/convert_property.go 1.20% <0.00%> (-0.04%) ⬇️
server/internal/adapter/gql/gqlmodel/models.go 0.00% <0.00%> (ø)
server/pkg/value/array.go 0.00% <0.00%> (ø)
server/pkg/property/value_timeline.go 0.00% <0.00%> (ø)

@pyshx pyshx merged commit dcbe9d1 into main Oct 27, 2023
16 of 17 checks passed
@pyshx pyshx deleted the chore/add-array-value-type branch October 27, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant