Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): date time field input #767

Merged
merged 12 commits into from
Oct 27, 2023
Merged

chore(web): date time field input #767

merged 12 commits into from
Oct 27, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • Improved date time field input

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 8ae2d47
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/653b51271c60da00083e8f19
😎 Deploy Preview https://deploy-preview-767--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 25, 2023
@mkumbobeaty mkumbobeaty removed the request for review from nina992 October 25, 2023 17:05
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #767 (8ae2d47) into main (4a3d089) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 0.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   26.38%   26.35%   -0.04%     
==========================================
  Files        1605     1606       +1     
  Lines      175690   175879     +189     
  Branches     3930     3932       +2     
==========================================
- Hits        46356    46345      -11     
- Misses     128245   128445     +200     
  Partials     1089     1089              
Flag Coverage Δ
web 24.64% <0.65%> (-0.06%) ⬇️
web-beta 24.64% <0.65%> (-0.06%) ⬇️
web-classic 24.64% <0.65%> (-0.06%) ⬇️
web-utils 24.64% <0.65%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/components/Icon/icons.ts 100.00% <100.00%> (ø)
.../src/beta/components/fields/common/PanelCommon.tsx 0.00% <ø> (ø)
.../beta/components/fields/common/TextInput/index.tsx 0.00% <ø> (ø)
...mponents/fields/CameraField/CapturePanel/index.tsx 0.00% <0.00%> (ø)
.../components/fields/CameraField/EditPanel/index.tsx 0.00% <0.00%> (ø)
...components/fields/DateTimeField/EditPanel/hooks.ts 0.00% <0.00%> (ø)
...src/beta/components/fields/DateTimeField/index.tsx 0.00% <0.00%> (ø)
...omponents/fields/DateTimeField/EditPanel/index.tsx 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

web/package.json Outdated Show resolved Hide resolved
@mkumbobeaty mkumbobeaty requested review from nina992 and removed request for jashanbhullar October 26, 2023 22:20
@mkumbobeaty mkumbobeaty merged commit 466362e into main Oct 27, 2023
15 of 16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/datetime branch October 27, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants