Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I added
idProperty
toData
type to get id from property. Basically NLS generates id automatically, but tileset's feature have id in property, and Cesium can't detect this property. So NLS generated id for feature by using tileset content's coordinates and index of feature in tileset content, but sometimes tileset has duplicated features in different tileset content. This causes some unexpected behavior like we can't search feature correctly. So I added functinoality to detect id correctly.What I've done
idProperty
toData
typeWhat I haven't done
How I tested
Which point I want you to review particularly
Memo