Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add idProperty to data #731

Merged
merged 2 commits into from
Oct 11, 2023
Merged

chore: add idProperty to data #731

merged 2 commits into from
Oct 11, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Oct 10, 2023

Overview

I added idProperty to Data type to get id from property. Basically NLS generates id automatically, but tileset's feature have id in property, and Cesium can't detect this property. So NLS generated id for feature by using tileset content's coordinates and index of feature in tileset content, but sometimes tileset has duplicated features in different tileset content. This causes some unexpected behavior like we can't search feature correctly. So I added functinoality to detect id correctly.

What I've done

  • Added idProperty to Data type

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 963c7cb
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6526466a7839b00009b2e731
😎 Deploy Preview https://deploy-preview-731--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #731 (bde65c9) into main (0853baf) will increase coverage by 0.03%.
The diff coverage is 23.07%.

❗ Current head bde65c9 differs from pull request most recent head 963c7cb. Consider uploading reports for the commit 963c7cb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
+ Coverage   26.74%   26.77%   +0.03%     
==========================================
  Files        1582     1574       -8     
  Lines      172304   172134     -170     
  Branches     3913     3913              
==========================================
+ Hits        46079    46096      +17     
+ Misses     125136   124949     -187     
  Partials     1089     1089              
Flag Coverage Δ
web 25.09% <23.07%> (+<0.01%) ⬆️
web-beta 25.09% <23.07%> (+<0.01%) ⬆️
web-classic 25.09% <23.07%> (+<0.01%) ⬆️
web-utils 25.09% <23.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/mantle/types/index.ts 100.00% <100.00%> (ø)
...b/src/beta/lib/core/engines/Cesium/useEngineRef.ts 45.03% <36.84%> (+0.89%) ⬆️
web/src/beta/lib/core/engines/Cesium/utils.ts 15.10% <19.04%> (+0.30%) ⬆️
...a/lib/core/engines/Cesium/Feature/Tileset/hooks.ts 16.46% <18.00%> (+0.47%) ⬆️

... and 22 files with indirect coverage changes

@keiya01 keiya01 merged commit ef58856 into main Oct 11, 2023
10 checks passed
@keiya01 keiya01 deleted the feat/id-property branch October 11, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants