Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): show installed widgets & fix computed feature property #727

Merged
merged 6 commits into from
Oct 8, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Oct 6, 2023

Overview

This PR:

  • Allows show installed widgets.
  • Fixs the computed feature property.
  • Comment the setting id for legacy layer to avoid crash.

THIS IS REQUIRED FOR SHOW CASE.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6d9325b
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6520170e44ae43000849239c
😎 Deploy Preview https://deploy-preview-727--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 6, 2023
@airslice airslice marked this pull request as ready for review October 6, 2023 09:24
@airslice airslice requested a review from KaWaite as a code owner October 6, 2023 09:24
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #727 (6d9325b) into main (124d3c1) will decrease coverage by 0.01%.
The diff coverage is 18.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   26.77%   26.77%   -0.01%     
==========================================
  Files        1574     1574              
  Lines      172097   172105       +8     
  Branches     3913     3913              
==========================================
+ Hits        46080    46081       +1     
- Misses     124928   124935       +7     
  Partials     1089     1089              
Flag Coverage Δ
web 25.08% <18.18%> (-0.01%) ⬇️
web-beta 25.08% <18.18%> (-0.01%) ⬇️
web-classic 25.08% <18.18%> (-0.01%) ⬇️
web-utils 25.08% <18.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/Map/Layers/hooks.ts 96.59% <100.00%> (+<0.01%) ⬆️
web/src/services/api/widgetsApi/utils.ts 42.35% <0.00%> (ø)
...b/src/beta/lib/core/engines/Cesium/useEngineRef.ts 44.14% <0.00%> (-0.51%) ⬇️

... and 2 files with indirect coverage changes

@airslice airslice requested a review from keiya01 as a code owner October 6, 2023 10:58
@airslice airslice changed the title chore(web): show installed widgets chore(web): show installed widgets & fix computed feature property Oct 6, 2023
@keiya01 keiya01 force-pushed the chore/show-installed-widgets branch from 1d57b10 to 6d9325b Compare October 6, 2023 14:17
@airslice airslice merged commit 5e9eddf into main Oct 8, 2023
16 checks passed
@airslice airslice deleted the chore/show-installed-widgets branch October 8, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants