Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): refactor assets hooks #719

Merged
merged 12 commits into from
Oct 12, 2023
Merged

chore(web): refactor assets hooks #719

merged 12 commits into from
Oct 12, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Oct 3, 2023

Overview

This pr is for refactoring the asset

What I've done

  1. merge the two existing hooks related to asset
  2. create a hook for file uploading
  3. move hooks to where they should be used.

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner October 3, 2023 19:10
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 18feb1d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6527942f9cbeac0008b000e0
😎 Deploy Preview https://deploy-preview-719--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #719 (18feb1d) into main (2476c3b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   26.73%   26.73%           
=======================================
  Files        1583     1583           
  Lines      172835   172757   -78     
  Branches     3913     3913           
=======================================
- Hits        46199    46193    -6     
+ Misses     125547   125475   -72     
  Partials     1089     1089           
Flag Coverage Δ
web 25.08% <0.00%> (+<0.01%) ⬆️
web-beta 25.08% <0.00%> (+<0.01%) ⬆️
web-classic 25.08% <0.00%> (+<0.01%) ⬆️
web-utils 25.08% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/components/fields/URLField/index.tsx 0.00% <0.00%> (ø)
...ProjectSettings/innerPages/AssetSettings/index.tsx 0.00% <0.00%> (ø)
web/src/beta/hooks/useAssetUploader/hooks.tsx 0.00% <0.00%> (ø)
.../innerPages/AssetSettings/AssetContainer/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Modals/AssetModal/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Assets/hooks.ts 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@KaWaite KaWaite changed the title refactor(web): refactor assets hooks chore(web): refactor assets hooks Oct 10, 2023
@nina992 nina992 merged commit 53aa05b into main Oct 12, 2023
15 of 16 checks passed
@nina992 nina992 deleted the refactor/refactor-asset branch October 12, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants