-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): add timeline manager #718
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 26.74% 26.72% -0.03%
==========================================
Files 1582 1583 +1
Lines 172343 172793 +450
Branches 3913 3913
==========================================
+ Hits 46096 46178 +82
- Misses 125158 125526 +368
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Overview
This PR add a timeline manager to contral all time related task in reearth.
reearth.clock
.Extended clock API:
Reearth event:
Plugin can add an event listener on
timelinecommit
and check the propstimelineCommitter
to know whether some other component updates the timeline.Notice: this committer is widget level, if you have multiple timeline in one widget you need to handle the active state inside widget logic.
What I've done
timelineManager
inMap
.timelineManagerRef
inVisualizer
.timelinecommit
to plugin API.timeline: TimelineManagerRef
toMapRef
so that it can be used in StoryPanel in the future. For example:What I haven't done
How I tested
timeline.zip
Which point I want you to review particularly
Memo