Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): various bug fixes and refactoring #713

Merged
merged 10 commits into from
Sep 28, 2023
Merged

chore(web): various bug fixes and refactoring #713

merged 10 commits into from
Sep 28, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Sep 28, 2023

Overview

Sorry this is a batch bug fix, refactor, code/ui/ux improvement PR. I know they should be separate PRs. Bad me. Bad.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ee945ef
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65153866488c0700085f76b0
😎 Deploy Preview https://deploy-preview-713--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KaWaite KaWaite self-assigned this Sep 28, 2023
@github-actions github-actions bot added the web label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #713 (ee945ef) into main (c4cc874) will decrease coverage by 1.44%.
Report is 1 commits behind head on main.
The diff coverage is 10.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
- Coverage   28.18%   26.75%   -1.44%     
==========================================
  Files        1571     1567       -4     
  Lines      171841   171043     -798     
  Branches     3825     3894      +69     
==========================================
- Hits        48440    45769    -2671     
- Misses     122312   124185    +1873     
  Partials     1089     1089              
Flag Coverage Δ
web 25.06% <10.11%> (-1.79%) ⬇️
web-beta 25.06% <10.11%> (-1.79%) ⬇️
web-classic 25.06% <10.11%> (-1.79%) ⬇️
web-utils 25.06% <10.11%> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../beta/features/Editor/tabs/map/LeftPanel/index.tsx 0.00% <ø> (ø)
web/src/services/api/storytellingApi/blocks.ts 30.73% <100.00%> (+3.46%) ⬆️
web/src/beta/lib/core/StoryPanel/Block/index.tsx 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/PanelContent/index.tsx 0.00% <0.00%> (ø)
.../src/beta/lib/core/StoryPanel/Page/BlockAddBar.tsx 0.00% <0.00%> (ø)
web/src/services/api/widgetsApi/utils.ts 42.35% <54.54%> (+2.35%) ⬆️
...res/Editor/tabs/map/LeftPanel/GroupField/index.tsx 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/Block/builtin/index.ts 0.00% <0.00%> (-95.66%) ⬇️
...eatures/Editor/tabs/map/LeftPanel/Layers/index.tsx 0.00% <0.00%> (ø)
...src/beta/lib/core/StoryPanel/PanelContent/hooks.ts 0.00% <0.00%> (ø)
... and 7 more

... and 70 files with indirect coverage changes

@KaWaite KaWaite marked this pull request as ready for review September 28, 2023 08:25
@KaWaite KaWaite merged commit 2536415 into main Sep 28, 2023
15 of 17 checks passed
@KaWaite KaWaite deleted the prep-for-10/10 branch September 28, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant