Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): MD Block #712

Merged
merged 19 commits into from
Sep 29, 2023
Merged

chore(web): MD Block #712

merged 19 commits into from
Sep 29, 2023

Conversation

jashanbhullar
Copy link
Contributor

Overview

MD block

What I've done

  • Used the markdown component for MD Block
  • Hooked up with API

What I haven't done

  • NA

How I tested

  • StoryPanel UI

Which point I want you to review particularly

  • Implementation

Memo

NA

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit c82e028
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/651688b4b6f8480009497600
😎 Deploy Preview https://deploy-preview-712--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #712 (c82e028) into main (4a62abc) will decrease coverage by 0.02%.
The diff coverage is 2.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   26.74%   26.72%   -0.02%     
==========================================
  Files        1567     1569       +2     
  Lines      171080   171219     +139     
  Branches     3894     3896       +2     
==========================================
+ Hits        45751    45754       +3     
- Misses     124240   124376     +136     
  Partials     1089     1089              
Flag Coverage Δ
server 33.73% <ø> (ø)
web 25.02% <2.02%> (-0.03%) ⬇️
web-beta 25.02% <2.02%> (-0.03%) ⬇️
web-classic 25.02% <2.02%> (-0.03%) ⬇️
web-utils 25.02% <2.02%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/components/Markdown/index.tsx 67.85% <100.00%> (+0.28%) ⬆️
web/src/services/api/storytellingApi/blocks.ts 31.33% <100.00%> (+0.59%) ⬆️
...res/Editor/tabs/map/LeftPanel/Layers/LayerItem.tsx 0.00% <0.00%> (ø)
.../src/beta/lib/core/StoryPanel/Page/BlockAddBar.tsx 0.00% <0.00%> (ø)
...b/src/beta/components/PopoverMenuContent/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/ListItem/index.tsx 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/Block/builtin/index.ts 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/PanelContent/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useStorytelling.ts 0.00% <0.00%> (ø)
...b/core/StoryPanel/Block/builtin/Markdown/index.tsx 0.00% <0.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

@KaWaite KaWaite merged commit 8fd9d35 into main Sep 29, 2023
17 checks passed
@KaWaite KaWaite deleted the chore/web/md-block branch September 29, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants