Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix create & remove story block #700

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Sep 22, 2023

Overview

Add missing params pageId on create and remove story block.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 1796d0c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/650d4388a7c40b00080a9fe3
😎 Deploy Preview https://deploy-preview-700--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@airslice airslice marked this pull request as ready for review September 22, 2023 07:33
@github-actions github-actions bot added the web label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #700 (1796d0c) into main (5fe5126) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   27.94%   27.94%   -0.01%     
==========================================
  Files        1564     1564              
  Lines      170712   170725      +13     
  Branches     3825     3825              
==========================================
  Hits        47709    47709              
- Misses     121914   121927      +13     
  Partials     1089     1089              
Flag Coverage Δ
web 26.53% <0.00%> (-0.01%) ⬇️
web-beta 26.53% <0.00%> (-0.01%) ⬇️
web-classic 26.53% <0.00%> (-0.01%) ⬇️
web-utils 26.53% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/lib/core/StoryPanel/Block/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Block/types.ts 0.00% <0.00%> (ø)
.../src/beta/lib/core/StoryPanel/Page/BlockAddBar.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)

@KaWaite KaWaite merged commit 57bbc38 into main Sep 22, 2023
17 checks passed
@KaWaite KaWaite deleted the chore/fix-story-block-create-remove branch September 22, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants