Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): refactor/update Camera field #692

Merged
merged 19 commits into from
Sep 19, 2023
Merged

chore(web): refactor/update Camera field #692

merged 19 commits into from
Sep 19, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Sep 15, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit a9567be
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6509358adfc5fe0007ae8029
😎 Deploy Preview https://deploy-preview-692--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 15, 2023
@KaWaite KaWaite self-assigned this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #692 (a9567be) into main (fa36274) will decrease coverage by 0.05%.
The diff coverage is 1.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   26.65%   26.61%   -0.05%     
==========================================
  Files        1554     1560       +6     
  Lines      169949   170242     +293     
  Branches     3880     3886       +6     
==========================================
+ Hits        45303    45312       +9     
- Misses     123557   123841     +284     
  Partials     1089     1089              
Flag Coverage Δ
web 24.88% <1.75%> (-0.05%) ⬇️
web-beta 24.88% <1.75%> (-0.05%) ⬇️
web-classic 24.88% <1.75%> (-0.05%) ⬇️
web-utils 24.88% <1.75%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/components/Popover/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Slider/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Toggle/index.tsx 0.00% <0.00%> (ø)
...mponents/fields/CameraField/CapturePanel/index.tsx 0.00% <0.00%> (ø)
...a/components/fields/CameraField/EditPanel/hooks.ts 0.00% <0.00%> (ø)
.../components/fields/CameraField/EditPanel/index.tsx 0.00% <0.00%> (ø)
...beta/components/fields/CameraField/PanelCommon.tsx 0.00% <0.00%> (ø)
...b/src/beta/components/fields/CameraField/index.tsx 0.00% <0.00%> (ø)
...eb/src/beta/components/fields/CameraField/types.ts 0.00% <0.00%> (ø)
...src/beta/components/fields/LocationField/index.tsx 0.00% <0.00%> (ø)
... and 41 more

... and 1 file with indirect coverage changes

@KaWaite KaWaite marked this pull request as ready for review September 19, 2023 04:48
@KaWaite KaWaite changed the title chore(web): Story page camera chore(web): refactor/update Camera field Sep 19, 2023
@KaWaite KaWaite merged commit b15e426 into main Sep 19, 2023
18 checks passed
@KaWaite KaWaite deleted the story-page-camera branch September 19, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant