-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use radio group in Data source manage #680
Merged
nina992
merged 20 commits into
main
from
refactor--use-radio-group-in-data-source-manager
Sep 14, 2023
Merged
refactor: use radio group in Data source manage #680
nina992
merged 20 commits into
main
from
refactor--use-radio-group-in-data-source-manager
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
- Coverage 26.66% 26.66% -0.01%
==========================================
Files 1554 1554
Lines 169891 169914 +23
Branches 3880 3880
==========================================
Hits 45302 45302
- Misses 123500 123523 +23
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…or--use-radio-group-in-data-source-manager
KaWaite
reviewed
Sep 12, 2023
KaWaite
reviewed
Sep 12, 2023
KaWaite
reviewed
Sep 12, 2023
KaWaite
reviewed
Sep 12, 2023
KaWaite
reviewed
Sep 13, 2023
KaWaite
reviewed
Sep 13, 2023
KaWaite
reviewed
Sep 13, 2023
KaWaite
reviewed
Sep 13, 2023
KaWaite
reviewed
Sep 13, 2023
…or--use-radio-group-in-data-source-manager
KaWaite
reviewed
Sep 13, 2023
KaWaite
reviewed
Sep 13, 2023
Co-authored-by: KaWaite <[email protected]>
…or--use-radio-group-in-data-source-manager
KaWaite
reviewed
Sep 14, 2023
KaWaite
reviewed
Sep 14, 2023
KaWaite
reviewed
Sep 14, 2023
KaWaite
reviewed
Sep 14, 2023
KaWaite
reviewed
Sep 14, 2023
web/src/beta/features/Editor/DataSourceManager/DelimitedText/index.tsx
Outdated
Show resolved
Hide resolved
pyshx
approved these changes
Sep 14, 2023
KaWaite
approved these changes
Sep 14, 2023
nina992
deleted the
refactor--use-radio-group-in-data-source-manager
branch
September 14, 2023 07:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor data source manager to use Radio group component instead the classic one
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo