Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use radio group in Data source manage #680

Merged
merged 20 commits into from
Sep 14, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Sep 11, 2023

Overview

Refactor data source manager to use Radio group component instead the classic one

What I've done

image
image

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit e399c29
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6502b34aacff650008d13fbf
😎 Deploy Preview https://deploy-preview-680--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot requested a review from pyshx September 11, 2023 08:25
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #680 (e399c29) into main (a364159) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   26.66%   26.66%   -0.01%     
==========================================
  Files        1554     1554              
  Lines      169891   169914      +23     
  Branches     3880     3880              
==========================================
  Hits        45302    45302              
- Misses     123500   123523      +23     
  Partials     1089     1089              
Flag Coverage Δ
web 24.93% <0.00%> (-0.01%) ⬇️
web-beta 24.93% <0.00%> (-0.01%) ⬇️
web-classic 24.93% <0.00%> (-0.01%) ⬇️
web-utils 24.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../src/beta/components/RadioGroup/RadioBox/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/RadioGroup/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Slider/index.tsx 0.00% <0.00%> (ø)
...rc/beta/components/fields/PropertyFields/index.tsx 0.00% <0.00%> (ø)
.../features/Editor/DataSourceManager/Asset/index.tsx 0.00% <0.00%> (ø)
...s/Editor/DataSourceManager/DelimitedText/index.tsx 0.00% <0.00%> (ø)
.../beta/features/Editor/SidePanel/Settings/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/map/LeftPanel/GroupField/index.tsx 0.00% <0.00%> (ø)
... and 6 more

@nina992 nina992 merged commit 72a00bf into main Sep 14, 2023
17 checks passed
@nina992 nina992 deleted the refactor--use-radio-group-in-data-source-manager branch September 14, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants