Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Update select field usage #678

Merged
merged 14 commits into from
Sep 12, 2023
Merged

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Sep 11, 2023

Overview

Refactored code: replace classic components with beta components

What I've done

  • Update the select field in asset manager modal (in data source manager)

What I haven't done

  • Fixed the code

How I tested

  • Visual

Which point I want you to review particularly

  • Z-index usage
  • how to fix the closing of modal

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 284c6dc
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/650009ff1a85a30008ac26d1
😎 Deploy Preview https://deploy-preview-678--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 11, 2023
@jashanbhullar jashanbhullar marked this pull request as ready for review September 11, 2023 10:17
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #678 (284c6dc) into main (39d7c0e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   26.66%   26.66%   -0.01%     
==========================================
  Files        1555     1555              
  Lines      169733   169734       +1     
  Branches     3878     3878              
==========================================
  Hits        45262    45262              
- Misses     123382   123383       +1     
  Partials     1089     1089              
Flag Coverage Δ
web 24.93% <0.00%> (-0.01%) ⬇️
web-beta 24.93% <0.00%> (-0.01%) ⬇️
web-classic 24.93% <0.00%> (-0.01%) ⬇️
web-utils 24.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/components/Popover/index.tsx 0.00% <0.00%> (ø)
...b/src/beta/components/fields/SelectField/index.tsx 0.00% <0.00%> (ø)
.../features/Editor/DataSourceManager/Asset/index.tsx 0.00% <0.00%> (ø)

@jashanbhullar jashanbhullar merged commit 14b4468 into main Sep 12, 2023
16 checks passed
@jashanbhullar jashanbhullar deleted the chore/select/layer-editor branch September 12, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants