Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor text input component #677

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Sep 9, 2023

Overview

Refactoring the text input , to two separate component text input and text field.
image
image

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 9, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 07044b0
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64feab34f7c0970008581d1d
😎 Deploy Preview https://deploy-preview-677--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 9, 2023
@github-actions github-actions bot requested a review from pyshx September 9, 2023 14:30
@nina992 nina992 changed the title refactor(web):refactor text input component refactor: refactor text input component Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #677 (07044b0) into main (65beead) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   26.74%   26.73%   -0.01%     
==========================================
  Files        1552     1553       +1     
  Lines      169264   169289      +25     
  Branches     3875     3876       +1     
==========================================
  Hits        45262    45262              
- Misses     122913   122938      +25     
  Partials     1089     1089              
Flag Coverage Δ
web 25.01% <0.00%> (-0.01%) ⬇️
web-beta 25.01% <0.00%> (-0.01%) ⬇️
web-classic 25.01% <0.00%> (-0.01%) ⬇️
web-utils 25.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/beta/components/fields/PropertyFields/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/fields/TextField/index.tsx 0.00% <0.00%> (ø)
.../beta/components/fields/common/TextInput/index.tsx 0.00% <0.00%> (ø)
...abs/widgets/RightPanel/ContainerSettings/index.tsx 0.00% <0.00%> (ø)
...ojectSettings/innerPages/GeneralSettings/index.tsx 0.00% <0.00%> (ø)
.../PluginSettings/PluginInstall/PublicRepo/index.tsx 0.00% <0.00%> (ø)
...innerPages/PublicSettings/PublicSettingsDetail.tsx 0.00% <0.00%> (ø)

@nina992 nina992 merged commit ee4fade into main Sep 11, 2023
16 checks passed
@nina992 nina992 deleted the refactor(web)/refactor-textInput-component branch September 11, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants