Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix HBAO error when Cesium is destroyed #675

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Sep 8, 2023

Overview

In VIEW3.0, application is crashed when back to the dashboard while HBAO is enabled. So I fixed this error.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 300ed59
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64fecdf0f748e800089fdfc3
😎 Deploy Preview https://deploy-preview-675--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 8, 2023
@github-actions github-actions bot requested a review from pyshx September 8, 2023 09:03
@keiya01 keiya01 merged commit 5e41ba7 into main Sep 11, 2023
6 checks passed
@keiya01 keiya01 deleted the fix/hbao-error branch September 11, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants