Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): include single selection to the selection mode #643

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Aug 24, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Aug 24, 2023
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 47d0567
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64e72fb8f2ee7100086176c5
😎 Deploy Preview https://deploy-preview-643--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #643 (47d0567) into main (fdd4eeb) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   27.91%   27.91%   -0.01%     
==========================================
  Files        1459     1459              
  Lines      158957   158958       +1     
  Branches     3737     3737              
==========================================
  Hits        44378    44378              
- Misses     113489   113490       +1     
  Partials     1090     1090              
Flag Coverage Δ
web 26.07% <0.00%> (-0.01%) ⬇️
web-beta 26.07% <0.00%> (-0.01%) ⬇️
web-classic 26.07% <0.00%> (-0.01%) ⬇️
web-utils 26.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/lib/core/Crust/interactionMode.ts 0.00% <0.00%> (ø)

@keiya01 keiya01 requested a review from airslice August 28, 2023 02:09
@keiya01 keiya01 merged commit 864d09a into main Aug 28, 2023
16 of 17 checks passed
@keiya01 keiya01 deleted the fix/selection-mode branch August 28, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants