-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): create workspace beta modal design #597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nina992
changed the title
fix(web):create workspace beta modal design
fix(web): create workspace beta modal design
Jul 27, 2023
KaWaite
reviewed
Jul 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
=======================================
Coverage 28.17% 28.18%
=======================================
Files 1419 1419
Lines 152573 152494 -79
Branches 3637 3637
=======================================
- Hits 42992 42975 -17
+ Misses 108425 108367 -58
+ Partials 1156 1152 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KaWaite
approved these changes
Jul 28, 2023
airslice
approved these changes
Jul 28, 2023
…eate-workspace-modal-design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Create workspace modal design had a side empty space so in this pr I fixed it
so the fixed one is :
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo