Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): gpx parsing not working #590

Merged
merged 14 commits into from
Jul 31, 2023
Merged

fix(web): gpx parsing not working #590

merged 14 commits into from
Jul 31, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Jul 26, 2023

Overview

This PR fixes issue observed while Parsing gpx data and In previous implementation utilizing 3rd party parser was leading to missing of data and mismatch of issue. This refactor should address the issue and make gpx parsing functioning.

@pyshx pyshx requested a review from keiya01 as a code owner July 26, 2023 06:04
@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for reearth-web failed.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64c7e24d073d992093ec7b43

@github-actions github-actions bot added the web label Jul 26, 2023
@github-actions github-actions bot requested a review from nina992 July 26, 2023 06:04
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #590 (446727b) into main (9eea0f9) will increase coverage by 0.31%.
The diff coverage is 66.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   28.37%   28.68%   +0.31%     
==========================================
  Files        1448     1434      -14     
  Lines      156219   155466     -753     
  Branches     3647     3755     +108     
==========================================
+ Hits        44322    44594     +272     
+ Misses     110740   109720    -1020     
+ Partials     1157     1152       -5     
Flag Coverage Δ
web 26.71% <66.26%> (+0.35%) ⬆️
web-beta 26.71% <66.26%> (+0.35%) ⬆️
web-classic 26.71% <66.26%> (+0.35%) ⬆️
web-utils 26.71% <66.26%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/classic/core/mantle/data/gpx.ts 68.29% <66.05%> (+35.22%) ⬆️
web/src/beta/lib/core/mantle/data/gpx.ts 68.60% <66.47%> (+35.53%) ⬆️

... and 25 files with indirect coverage changes

@pyshx pyshx merged commit 35d6daa into main Jul 31, 2023
12 of 16 checks passed
@pyshx pyshx deleted the fix/gpx-data branch July 31, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants