Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): unsafe plugin support #576

Merged
merged 27 commits into from
Jul 28, 2023
Merged

chore(web): unsafe plugin support #576

merged 27 commits into from
Jul 28, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Jul 12, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for reearth-web failed.

Name Link
🔨 Latest commit 5f980d6
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64c3b471d40dae000831603d

@KaWaite KaWaite changed the title chore(web): builtin plugin support chore(web): unsafe plugin support Jul 12, 2023
@github-actions github-actions bot added the web label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #576 (5f980d6) into main (1410264) will increase coverage by 0.01%.
The diff coverage is 45.58%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   28.17%   28.18%   +0.01%     
==========================================
  Files        1419     1422       +3     
  Lines      152575   152708     +133     
  Branches     3637     3641       +4     
==========================================
+ Hits        42992    43046      +54     
- Misses     108427   108506      +79     
  Partials     1156     1156              
Flag Coverage Δ
server 36.30% <ø> (ø)
web 26.05% <45.58%> (+0.01%) ⬆️
web-beta 26.05% <45.58%> (+0.01%) ⬆️
web-classic 26.05% <45.58%> (+0.01%) ⬆️
web-utils 26.05% <45.58%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...features/Editor/tabs/widgets/Nav/Devices/index.tsx 0.00% <0.00%> (ø)
...Crust/Widgets/Widget/builtin/Button/MenuButton.tsx 0.00% <0.00%> (ø)
...core/Crust/Widgets/Widget/builtin/Button/index.tsx 0.00% <0.00%> (ø)
...t/Widgets/Widget/builtin/LegacyMenu/MenuButton.tsx 0.00% <0.00%> (ø)
.../Crust/Widgets/Widget/builtin/LegacyMenu/index.tsx 0.00% <0.00%> (ø)
...Crust/Widgets/Widget/builtin/Navigator/UI/hooks.ts 97.20% <ø> (ø)
...Crust/Widgets/Widget/builtin/Navigator/UI/types.ts 0.00% <ø> (ø)
...Crust/Widgets/Widget/builtin/Navigator/UI/utils.ts 100.00% <ø> (ø)
...re/Crust/Widgets/Widget/builtin/Navigator/hooks.ts 0.00% <0.00%> (ø)
...e/Crust/Widgets/Widget/builtin/Navigator/index.tsx 0.00% <0.00%> (ø)
... and 27 more

@KaWaite KaWaite marked this pull request as ready for review July 28, 2023 02:56
@github-actions github-actions bot removed the server label Jul 28, 2023
@KaWaite KaWaite merged commit 1ebef7e into main Jul 28, 2023
13 of 17 checks passed
@KaWaite KaWaite deleted the feat/builtin-plugin-support branch July 28, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants