Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Add storytelling static content of left panel #565

Merged
merged 23 commits into from
Jul 12, 2023

Conversation

isoppp
Copy link
Contributor

@isoppp isoppp commented Jul 7, 2023

Overview

I replaced the left side panel in the story tab with actual contents(static).

What I've done

What I haven't done

  • connect with state/API which means static now
  • popup contents
  • styles like selected or isActive

How I tested

image

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 87aa94a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64ae0de2cefc9e0008486ab1
😎 Deploy Preview https://deploy-preview-565--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #565 (87aa94a) into main (9ae1af5) will decrease coverage by 0.04%.
The diff coverage is 1.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   28.52%   28.49%   -0.04%     
==========================================
  Files        1385     1390       +5     
  Lines      149914   150121     +207     
  Branches     3587     3592       +5     
==========================================
+ Hits        42769    42771       +2     
- Misses     105993   106198     +205     
  Partials     1152     1152              
Flag Coverage Δ
web 26.38% <1.88%> (-0.05%) ⬇️
web-beta 26.38% <1.88%> (-0.05%) ⬇️
web-classic 26.38% <1.88%> (-0.05%) ⬇️
web-utils 26.38% <1.88%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/features/Editor/SidePanel/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
...features/Editor/tabs/story/PageIndicator/index.tsx 0.00% <0.00%> (ø)
...tures/Editor/tabs/story/SidePanel/Action/index.tsx 0.00% <0.00%> (ø)
.../Editor/tabs/story/SidePanel/ContentPage/index.tsx 0.00% <0.00%> (ø)
...Editor/tabs/story/SidePanel/ContentStory/index.tsx 0.00% <0.00%> (ø)
...eatures/Editor/tabs/story/SidePanel/Item/index.tsx 0.00% <0.00%> (ø)
...tor/tabs/story/SidePanel/PageItemWrapper/index.tsx 0.00% <0.00%> (ø)
...eta/features/Editor/tabs/story/SidePanel/index.tsx 0.00% <0.00%> (ø)
...ta/features/Editor/tabs/story/StoryPanel/index.tsx 0.00% <0.00%> (ø)
... and 4 more

@isoppp isoppp force-pushed the chore/st/left-panel-content branch from 793516a to a65611d Compare July 7, 2023 10:00
@isoppp isoppp marked this pull request as ready for review July 7, 2023 10:02
@isoppp isoppp requested a review from KaWaite as a code owner July 7, 2023 10:02
@github-actions github-actions bot requested a review from pyshx July 7, 2023 10:02
@KaWaite KaWaite changed the title chore(web): Add left panel content chore(web): Add left panel Storytelling content Jul 9, 2023
@isoppp isoppp requested a review from KaWaite July 10, 2023 06:25
@isoppp isoppp changed the title chore(web): Add left panel Storytelling content chore(web): Add left panel Storytelling static content Jul 10, 2023
@isoppp isoppp changed the title chore(web): Add left panel Storytelling static content chore(web): Add storytelling static content of left panel Jul 10, 2023
Copy link
Contributor

@pyshx pyshx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small Suggestion. Rest LGTM!

@isoppp isoppp force-pushed the chore/st/left-panel-content branch from 57e34a2 to b86dfa0 Compare July 10, 2023 07:58
@isoppp isoppp merged commit 65c1a14 into main Jul 12, 2023
16 checks passed
@isoppp isoppp deleted the chore/st/left-panel-content branch July 12, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants