Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): filter properties in property.FindByIDs #548

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Jul 2, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@orisano orisano requested a review from rot1024 as a code owner July 2, 2023 12:15
@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit ed809a6
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64a16a674cefe600087b6e2f

@github-actions github-actions bot added the server label Jul 2, 2023
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #548 (ed809a6) into main (b0621c4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   26.67%   26.66%   -0.01%     
==========================================
  Files        1343     1343              
  Lines      144972   144984      +12     
  Branches     3485     3485              
==========================================
  Hits        38667    38667              
- Misses     105158   105170      +12     
  Partials     1147     1147              
Flag Coverage Δ
server 36.26% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/internal/infrastructure/mongo/property.go 0.00% <0.00%> (ø)

@rot1024 rot1024 changed the title feat(server): implement go scene filter fix(server): filter properties in property.FindByIDs Jul 2, 2023
@rot1024 rot1024 merged commit 47ce14c into main Jul 2, 2023
@rot1024 rot1024 deleted the feat/go-scene-filter branch July 2, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants