Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): add schema field ID to dataset REST API #547

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Jul 2, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit ccc7d7b
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64a14c9993200b000863d8b7

@github-actions github-actions bot added the server label Jul 2, 2023
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #547 (ccc7d7b) into main (02e25c1) will increase coverage by 0.00%.
The diff coverage is 51.16%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   26.67%   26.67%           
=======================================
  Files        1343     1343           
  Lines      144960   144972   +12     
  Branches     3485     3485           
=======================================
+ Hits        38662    38667    +5     
- Misses     105154   105158    +4     
- Partials     1144     1147    +3     
Flag Coverage Δ
server 36.28% <51.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/pkg/dataset/export.go 42.99% <0.00%> (ø)
server/pkg/property/value_camera.go 18.30% <0.00%> (ø)
server/pkg/property/value_typography.go 42.62% <0.00%> (ø)
server/pkg/value/bool.go 45.94% <0.00%> (ø)
server/pkg/value/coordinates.go 0.00% <0.00%> (ø)
server/pkg/value/latlng.go 25.80% <0.00%> (ø)
server/pkg/value/latlngheight.go 13.63% <0.00%> (ø)
server/pkg/value/number.go 24.40% <0.00%> (ø)
server/pkg/value/polygon.go 0.00% <0.00%> (ø)
server/pkg/value/rect.go 0.00% <0.00%> (ø)
... and 9 more

@rot1024 rot1024 merged commit b0621c4 into main Jul 2, 2023
@rot1024 rot1024 deleted the dataset-field-id branch July 2, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant