Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add empty StoryPanel #541

Merged
merged 7 commits into from
Jul 7, 2023

Conversation

isoppp
Copy link
Contributor

@isoppp isoppp commented Jun 30, 2023

Overview

Add an empty story panel and set common colors

What I've done

What I haven't done

This component will be difficult to maintain storybook so I didn't create it.

How I tested

see editor in local

image

Which point I want you to review particularly

Memo

@isoppp isoppp requested a review from KaWaite as a code owner June 30, 2023 09:01
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 2ec481a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64a766d0cc22b000081a683b
😎 Deploy Preview https://deploy-preview-541--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #541 (2ec481a) into main (591800f) will decrease coverage by 0.01%.
The diff coverage is 3.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   25.62%   25.61%   -0.01%     
==========================================
  Files        1360     1361       +1     
  Lines      154550   154563      +13     
  Branches     3557     3558       +1     
==========================================
- Hits        39599    39596       -3     
- Misses     113799   113815      +16     
  Partials     1152     1152              
Flag Coverage Δ
web 22.84% <3.70%> (-0.01%) ⬇️
web-beta 22.84% <3.70%> (-0.01%) ⬇️
web-classic 22.84% <3.70%> (-0.01%) ⬇️
web-utils 22.84% <3.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ures/Editor/Tabs/Storytelling/StoryPanel/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
web/src/services/theme/reearthTheme/types.ts 0.00% <0.00%> (ø)
...eb/src/services/theme/reearthTheme/common/index.ts 100.00% <100.00%> (ø)

@github-actions github-actions bot requested a review from pyshx June 30, 2023 09:13
@isoppp isoppp merged commit 65ba8c0 into main Jul 7, 2023
@isoppp isoppp deleted the chore/beta-storytelling/page-component branch July 7, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants