Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): support with Authentication function support for cognito backend #514

Merged
merged 8 commits into from
Jul 4, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Jun 22, 2023

Overview

This PR adds support for withAuthentication function support for backend which is using cognito.

What I've done

I've added withAuthentication function for cognito based authentication mode.

How I tested

Fire-up local using cognito authentication provider and try to copy the url of the earthEditor or any page which required Authentication and use it in incognito mode. If it redirects to login page of cognito then its working.

@pyshx pyshx requested a review from KaWaite as a code owner June 22, 2023 10:15
@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5fee0e2
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64a3d712e99c4f0008c192dc
😎 Deploy Preview https://deploy-preview-514--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jun 22, 2023
@github-actions github-actions bot requested a review from nina992 June 22, 2023 10:15
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #514 (5fee0e2) into main (38489c3) will decrease coverage by 0.01%.
The diff coverage is 9.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
- Coverage   27.32%   27.32%   -0.01%     
==========================================
  Files        1345     1345              
  Lines      144958   144972      +14     
  Branches     3541     3541              
==========================================
+ Hits        39605    39607       +2     
- Misses     104201   104213      +12     
  Partials     1152     1152              
Flag Coverage Δ
web 24.79% <9.75%> (-0.01%) ⬇️
web-beta 24.79% <9.75%> (-0.01%) ⬇️
web-classic 24.79% <9.75%> (-0.01%) ⬇️
web-utils 24.79% <9.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b/src/classic/components/pages/Dashboard/index.tsx 0.00% <0.00%> (ø)
...src/classic/components/pages/EarthEditor/index.tsx 0.00% <0.00%> (ø)
web/src/classic/components/pages/Preview/index.tsx 0.00% <0.00%> (ø)
...lassic/components/pages/Settings/Account/index.tsx 0.00% <0.00%> (ø)
...omponents/pages/Settings/Project/Dataset/index.tsx 0.00% <0.00%> (ø)
...components/pages/Settings/Project/Plugin/index.tsx 0.00% <0.00%> (ø)
...components/pages/Settings/Project/Public/index.tsx 0.00% <0.00%> (ø)
...lassic/components/pages/Settings/Project/index.tsx 0.00% <0.00%> (ø)
...ic/components/pages/Settings/ProjectList/index.tsx 0.00% <0.00%> (ø)
...omponents/pages/Settings/Workspace/Asset/index.tsx 0.00% <0.00%> (ø)
... and 3 more

@pyshx pyshx enabled auto-merge (squash) July 4, 2023 08:26
@pyshx pyshx merged commit c603f7b into main Jul 4, 2023
@pyshx pyshx deleted the fix/add-with-auth-func-support branch July 4, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants