Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): theme system #498

Merged
merged 31 commits into from
Jun 13, 2023
Merged

refactor(web): theme system #498

merged 31 commits into from
Jun 13, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Jun 9, 2023

Overview

The theme code in reearth is the result of a few iterations and design systems over the years being partially adhered to. This Pr tries to clean up the theme system a bit and set some standards to file/folder structure.

This should perhaps be considered WIP, as I am not fully satisfied.

What I've done

  • Reorganize services/theme
    • Better organize folders
      • ex. themes are broken up, reearth themes and publish themes are split and have similar structure, etc
    • Colors are split better
  • More strongly type
  • Split theme between classic and beta so we don't have to worry about breaking classic styles (this includes changes to routes to wrap classic routes in classic's theme provider)

Which point I want you to review particularly

You can just focus on the code in services/theme. Everything else will be just import adjustments and fixes to theme/color use inside of styled components

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 3a5a192
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6487fefe52240300083f8084
😎 Deploy Preview https://deploy-preview-498--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the web label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #498 (3a5a192) into main (0eed12c) will decrease coverage by 0.44%.
The diff coverage is 44.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   26.70%   26.26%   -0.44%     
==========================================
  Files        1282     1315      +33     
  Lines      141479   142980    +1501     
  Branches     3442     3469      +27     
==========================================
- Hits        37783    37556     -227     
- Misses     102574   104302    +1728     
  Partials     1122     1122              
Flag Coverage Δ
web 23.44% <44.14%> (-0.53%) ⬇️
web-beta 23.44% <44.14%> (-0.53%) ⬇️
web-classic 23.44% <44.14%> (-0.53%) ⬇️
web-utils 23.44% <44.14%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/Crust/Plugins/Plugin/ModalContainer/index.tsx 0.00% <0.00%> (ø)
...core/Crust/Plugins/Plugin/PopupContainer/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/theme/dark.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/theme/forest.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/theme/light.ts 0.00% <0.00%> (ø)
web/src/classic/components/atoms/Button/index.tsx 0.00% <0.00%> (ø)
web/src/classic/components/atoms/Check/index.tsx 0.00% <0.00%> (ø)
...assic/components/atoms/PublicationStatus/index.tsx 0.00% <0.00%> (ø)
web/src/classic/components/atoms/Radio/index.tsx 0.00% <0.00%> (ø)
web/src/classic/components/atoms/Table/index.tsx 0.00% <0.00%> (ø)
... and 119 more

@KaWaite KaWaite marked this pull request as ready for review June 13, 2023 02:26
@KaWaite KaWaite requested a review from keiya01 as a code owner June 13, 2023 02:26
@github-actions github-actions bot requested a review from pyshx June 13, 2023 02:26
@KaWaite KaWaite self-assigned this Jun 13, 2023
Copy link
Contributor

@pyshx pyshx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@KaWaite KaWaite merged commit b7fa18e into main Jun 13, 2023
@KaWaite KaWaite deleted the refactor-theme-directory branch June 13, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants