Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(web): Add StorytellingPageSectionItem #495

Merged
merged 20 commits into from
Jun 23, 2023

Conversation

atnagata
Copy link
Contributor

@atnagata atnagata commented Jun 9, 2023

Overview

Add StorytellingPageSectionItem

@atnagata atnagata requested a review from KaWaite as a code owner June 9, 2023 02:16
@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit b90f801
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/649543517b1b5b0008cc31fc
😎 Deploy Preview https://deploy-preview-495--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot requested review from keiya01 and nina992 June 9, 2023 02:16
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #495 (b90f801) into main (4b70565) will decrease coverage by 0.02%.
The diff coverage is 6.97%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   26.66%   26.65%   -0.02%     
==========================================
  Files        1335     1336       +1     
  Lines      144542   144628      +86     
  Branches     3482     3483       +1     
==========================================
+ Hits        38549    38555       +6     
- Misses     104871   104951      +80     
  Partials     1122     1122              
Flag Coverage Δ
web 23.98% <6.97%> (-0.02%) ⬇️
web-beta 23.98% <6.97%> (-0.02%) ⬇️
web-classic 23.98% <6.97%> (-0.02%) ⬇️
web-utils 23.98% <6.97%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/components/StorytellingPageSectionItem/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/Icon/icons.ts 100.00% <100.00%> (ø)

@keiya01
Copy link
Member

keiya01 commented Jun 15, 2023

Could you add the multiple-line case as Storybook component? ActionButton is hidden when line is broken.
Screenshot 2023-06-15 at 14 51 12

@KaWaite KaWaite merged commit 36ddb20 into reearth:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants