Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add theming support for components in storybook #481

Merged
merged 6 commits into from
Jun 8, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Jun 7, 2023

Overview

Add theming support to components in storybook.
The background still needs to be changed separately..
Updated Modal component's story.

@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit cb2b885
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/648175c20c348b0008281fc4
😎 Deploy Preview https://deploy-preview-481--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the web label Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #481 (cb2b885) into main (90c38eb) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   26.71%   26.70%   -0.02%     
==========================================
  Files        1279     1280       +1     
  Lines      141225   141298      +73     
  Branches     3436     3436              
==========================================
  Hits        37735    37735              
- Misses     102369   102442      +73     
  Partials     1121     1121              
Flag Coverage Δ
web 24.00% <100.00%> (+<0.01%) ⬆️
web-beta 24.00% <100.00%> (+<0.01%) ⬆️
web-classic 24.00% <100.00%> (+<0.01%) ⬆️
web-utils 24.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/services/theme/index.ts 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@KaWaite KaWaite merged commit 7cdea3c into main Jun 8, 2023
@KaWaite KaWaite deleted the feat/storybook-styled-themeing branch June 8, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants