Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): support AWS Cognito auth server #450

Merged
merged 4 commits into from
May 30, 2023
Merged

Conversation

yk-eukarya
Copy link
Contributor

No description provided.

@yk-eukarya yk-eukarya self-assigned this May 29, 2023
@yk-eukarya yk-eukarya requested a review from rot1024 as a code owner May 29, 2023 18:30
@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 20e3f3d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64759e4dbdd07900080242a5

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #450 (20e3f3d) into main (f27b788) will decrease coverage by 0.02%.
The diff coverage is 43.49%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   36.25%   36.24%   -0.02%     
==========================================
  Files         342      346       +4     
  Lines       30988    30987       -1     
==========================================
- Hits        11236    11231       -5     
- Misses      18651    18657       +6     
+ Partials     1101     1099       -2     
Flag Coverage Δ
server 36.24% <43.49%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/internal/app/app.go 0.00% <0.00%> (ø)
server/internal/app/auth_client.go 0.00% <0.00%> (ø)
server/internal/app/config/marketplace.go 0.00% <0.00%> (ø)
server/internal/app/graphql.go 0.00% <0.00%> (ø)
server/internal/app/jwt.go 0.00% <0.00%> (ø)
server/internal/app/main.go 0.00% <0.00%> (ø)
server/internal/app/repo.go 0.00% <0.00%> (ø)
server/internal/app/tracer.go 0.00% <0.00%> (ø)
server/internal/app/usecase.go 36.84% <0.00%> (+5.02%) ⬆️
server/internal/app/config/auth_server.go 22.22% <22.22%> (ø)
... and 6 more

Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating the config package is a very good idea.

server/internal/app/config/mailer.go Outdated Show resolved Hide resolved
server/internal/app/config.go Outdated Show resolved Hide resolved
server/internal/app/config.go Outdated Show resolved Hide resolved
@yk-eukarya yk-eukarya merged commit 2002db2 into main May 30, 2023
@yk-eukarya yk-eukarya deleted the feat/aws_cognito branch May 30, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants