Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): Re:Earth Beta routing and basic component structure #444

Merged
merged 12 commits into from
May 26, 2023
Merged

feat(web): Re:Earth Beta routing and basic component structure #444

merged 12 commits into from
May 26, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented May 25, 2023 •
edited
Loading

Overview

Adding Re:Earth Beta routes and a basic component structure.

What I've done

  • Add /scene/:sceneId/xxxx routing for beta
  • Added Editor page and basic component structure to editor
  • Added basic tab switching (Scene, Story, Widgets, Publish)
Screenshot 2023-05-26 at 12 27 40

What I haven't done

  • Any component level components. Just wrappers to build out the app structure
  • Any finalized logic to tab switching (this can be (and probably will be) completely overhauled later.

Which point I want you to review particularly

  • Route naming

@netlify
Copy link

netlify bot commented May 25, 2023 •
edited
Loading

✅ Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 0fb5084
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6470545928017000088bc5a0
😎 Deploy Preview https://deploy-preview-444--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KaWaite KaWaite changed the title feat(web): beta routing and basic component structure feat(web): Re:Earth Beta routing and basic component structure May 25, 2023
@github-actions github-actions bot added the web label May 25, 2023
@KaWaite KaWaite marked this pull request as ready for review May 26, 2023 03:30
isoppp
isoppp approved these changes May 26, 2023
View reviewed changes
web/src/app.tsx Show resolved Hide resolved
web/src/app.tsx Show resolved Hide resolved
web/src/app.tsx Outdated Show resolved Hide resolved
@KaWaite KaWaite merged commit 75b7bb9 into main May 26, 2023
@KaWaite KaWaite deleted the feat/beta-routing branch May 26, 2023 06:46
@isoppp isoppp mentioned this pull request May 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiya01 keiya01 keiya01 left review comments

@isoppp isoppp isoppp approved these changes

Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaWaite @isoppp @keiya01