Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): support AWS S3 storage #440

Merged
merged 14 commits into from
May 30, 2023
Merged

feat(server): support AWS S3 storage #440

merged 14 commits into from
May 30, 2023

Conversation

yk-eukarya
Copy link
Contributor

No description provided.

@yk-eukarya yk-eukarya self-assigned this May 23, 2023
@yk-eukarya yk-eukarya requested a review from rot1024 as a code owner May 23, 2023 16:50
@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 2820d27
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6475adae9430a70008d0a98e

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #440 (2820d27) into main (2002db2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   36.24%   36.23%   -0.02%     
==========================================
  Files         346      347       +1     
  Lines       30987    30998      +11     
==========================================
  Hits        11231    11231              
- Misses      18657    18668      +11     
  Partials     1099     1099              
Flag Coverage Δ
server 36.23% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/internal/app/config/config.go 44.64% <ø> (ø)
server/internal/app/config/file.go 0.00% <0.00%> (ø)
server/internal/app/repo.go 0.00% <0.00%> (ø)

# Conflicts:
#	server/go.mod
#	server/go.sum
#	server/internal/app/config.go
#	server/internal/app/repo.go
#	server/internal/infrastructure/storage/file.go
# Conflicts:
#	server/internal/app/repo.go
server/internal/infrastructure/s3/aws_s3.go Outdated Show resolved Hide resolved
server/internal/infrastructure/s3/aws_s3.go Outdated Show resolved Hide resolved
server/internal/infrastructure/s3/aws_s3.go Outdated Show resolved Hide resolved
server/internal/app/repo.go Outdated Show resolved Hide resolved
server/internal/app/config.go Outdated Show resolved Hide resolved
server/internal/app/config.go Outdated Show resolved Hide resolved
# Conflicts:
#	server/go.mod
#	server/internal/app/config.go
#	server/internal/app/repo.go
@yk-eukarya yk-eukarya merged commit 8c56c74 into main May 30, 2023
@yk-eukarya yk-eukarya deleted the feat/s3_storage branch May 30, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants