Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): plugin update cause layer corruption #431

Merged
merged 15 commits into from
Jun 1, 2023
Merged

Conversation

yk-eukarya
Copy link
Contributor

No description provided.

@yk-eukarya yk-eukarya self-assigned this May 18, 2023
@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 39afb43
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64784244214ec10008b5d3f7

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #431 (39afb43) into main (7c89bfd) will increase coverage by 0.03%.
The diff coverage is 81.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   24.62%   24.65%   +0.03%     
==========================================
  Files        1048     1049       +1     
  Lines      111940   111995      +55     
  Branches     2138     2138              
==========================================
+ Hits        27562    27613      +51     
+ Misses      83279    83278       -1     
- Partials     1099     1104       +5     
Flag Coverage Δ
server 36.33% <81.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/internal/usecase/interactor/scene_plugin.go 50.55% <0.00%> (-0.28%) ⬇️
server/pkg/layer/infobox_field_builder.go 81.48% <0.00%> (-1.28%) ⬇️
server/pkg/layer/id_list.go 58.02% <80.00%> (+0.79%) ⬆️
server/pkg/layer/list.go 33.77% <80.00%> (+4.94%) ⬆️
server/pkg/id/property_schema_list.go 85.36% <85.36%> (ø)
server/pkg/scene/plugins.go 95.78% <88.88%> (-2.13%) ⬇️
server/pkg/layer/infobox_field.go 43.33% <100.00%> (+11.33%) ⬆️
server/pkg/plugin/plugin.go 67.02% <100.00%> (ø)

@yk-eukarya yk-eukarya requested a review from rot1024 as a code owner May 26, 2023 20:47
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/layer/infobox_field_builder.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Show resolved Hide resolved
server/pkg/layer/infobox_field.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/layer/infobox_field.go Outdated Show resolved Hide resolved
server/pkg/scene/sceneops/plugin_migrator.go Outdated Show resolved Hide resolved
server/pkg/layer/infobox_field.go Outdated Show resolved Hide resolved
@yk-eukarya yk-eukarya merged commit f2dd7be into main Jun 1, 2023
@yk-eukarya yk-eukarya deleted the fix/plugin_update branch June 1, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants