Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tag]Link tags to dataset #67

Closed
2 of 28 tasks
yk-eukarya opened this issue Jul 26, 2021 · 0 comments
Closed
2 of 28 tasks

[Tag]Link tags to dataset #67

yk-eukarya opened this issue Jul 26, 2021 · 0 comments
Assignees
Labels

Comments

@yk-eukarya
Copy link
Contributor

yk-eukarya commented Jul 26, 2021

Requirements

  • Query n Mutation
    • Query
      • Tags belonging to the scene. If the tag is linked to the dataset field, the tag must have that id.
      • Tags belonging to the linkedLayerGroup. e.g. If layer group A is linked with dataset A and there are "hoge", "fuga", and "foo" tags. The query to fetch tags of layer group A should return all of the tags its children have. ("hoge", "fuga" and "foo")
      • Query to get the selected dataset's columns list
    • Mutation
      - [ ] Tag attaching/detaching functionality will be changed depending on if the layer is a group or item
      - if it is a layer group this should be applied to all of its children
      - don't attach datset-linked tags to a group layer but they should be added to its children
      - alternatively, add all dataset-linked tags to the group layer and its children
      • CreateTagFromDatasetSchemaField
        • Input
          • DatasetSchemaId
          • DatasetSchemaFieldId
          • LayerId
          • SceneId
        • Output
          • Tags belonging to the scene
      • LinkTagsWithDataset
        All children layer of linkedLayerGroup must update their tags which have been generated from the dataset field.
        • Input
          • LayerId
          • DatasetSchemaId
          • DatasetSchemaFieldId
        • Output
          • List of tags that belongs to the layer group
      • UnlinkTagsWithDataset
        All children layer of linkedLayerGroup must update(remove) their tags which have been generated from the dataset field
        • Input
          • LayerId
          • DatasetSchemaId
          • DatasetSchemaFieldId
        • Output
          • List of tags that belongs to the layer group
@HideBa HideBa added the backend label Aug 3, 2021
KeisukeYamashita pushed a commit that referenced this issue Aug 13, 2022
* feat: tag system domain models (#39)

* feat: tag system domain models

* refactor: * add tag interface * tag -> group and tag->item conversation

* testing: generate test cases for the tagID

* resolve notes

* fix unit tests errors

* add NewId test code
fix NewId func

* add more test cases
refactor some parts

* feat: tag system data-layer (mongo) (#44)

* feat: tag system data-layer (mongo)

* remove len > 0 check

* goimport

* Update pkg/tag/group_builder.go

Co-authored-by: rot1024 <[email protected]>

* Update pkg/tag/item_builder.go

Co-authored-by: rot1024 <[email protected]>

* rename itemFrom and groupFrom funcs

Co-authored-by: rot1024 <[email protected]>

* feat: create tag group and tag item (#45)

* tag item and group schema

* feat: creat tags (GQL schema)

* tag items and tag groups resolvers

* datalayer (dummy memory) and usecases

* receive list by reference

* check if nil for list

* resolve notes

* generate new models

* feat: memory infrastructure (#46)

* refactor: implement memory infrastructure

* test: implement memory infrastructure test cases

* test: fix FindByScene test case

* feat: attach/detach tag from layer (#50)

* tag item and group schema

* feat: creat tags (GQL schema)

* tag items and tag groups resolvers

* datalayer (dummy memory) and usecases

* receive list by reference

* check if nil for list

* feat: introduce tags to layers

* feat: attach/detach tags from layers

* fix imports

* refactor: resolve notes

* test: test units for tags

* refactor: resolve notes

* feat: attach/detach tag item from group (#52)

* refactor: transform group tags list to reference

* feat: attach/detach tags

* refactor: use params as use-case input

* test: mongodoc testing (#61)

* test: mongodoc testing

* resolve notes

* feat: remove tag (#58)

* feat: remove a tag (init)

* feat: remove tag

* feat: remove tag usecase and infra

* resolve notes

* feat: tag system queries (#54)

* feat: tag system queries

* resolve notes

* feat: update tag (#49)

* tag item and group schema

* feat: creat tags (GQL schema)

* tag items and tag groups resolvers

* datalayer (dummy memory) and usecases

* receive list by reference

* check if nil for list

* feat: rename tag group

* refactor: rename -> update

* resolve notes

* resolve notes

* change find by id func return type

* Merge branch 'tag-system' of https://github.com/reearth/reearth-backend into tag/update-group-label

# Conflicts:
#	internal/adapter/gql/generated.go
#	internal/adapter/gql/gqlmodel/convert_tag.go

* fix testing

* resolve notes

* resolve notes

* resolve notes

Co-authored-by: HideBa <[email protected]>
Co-authored-by: rot1024 <[email protected]>
pyshx pushed a commit that referenced this issue Apr 17, 2023
* Add scene theme

* Set main color of floating panel

* Add default values

* Fix menu buttons color

* Reflect backend changes

* Get rid of context

* refactor code

* Add comment

* Fix optional parameter

* Define variable type

* Fix custom color

* Fix typo

* visible param is not used

* Use tinyColor

* Remove unused code

* Add custom theme conditions

* Refactor

* Rename type

* Refactor code

* Refactor

* Fix color issue

* dummy comment

* remove dummy comment

* Remove important

* refactor (#78)

Co-authored-by: rot1024 <[email protected]>

* Fix colors

* Fix colors

Co-authored-by: basel.issmail <[email protected]>
Co-authored-by: rot1024 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants