Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): spelling, fix deploy handler imports, dedupe server builder #9949

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Feb 1, 2024

Follow up to #9948; missed a few things at the end there:

  • misspelled "description" in a test mock
  • the server file and both server handlers take the same options, so I deduped them
  • related, I wasn't passing apiRootPath through to the server file handler
  • I incorrectly accessed .handler on apiServerHandler in flightcontrol and render

@jtoar jtoar added the release:fix This PR is a fix label Feb 1, 2024
@jtoar jtoar added this to the v7.0.0 milestone Feb 1, 2024
@jtoar jtoar enabled auto-merge (squash) February 1, 2024 15:43
@jtoar jtoar merged commit 80f499e into main Feb 1, 2024
38 of 39 checks passed
@jtoar jtoar deleted the ds-server/post-dedupe-fixes branch February 1, 2024 15:51
jtoar added a commit that referenced this pull request Feb 1, 2024
…der (#9949)

Follow up to #9948; missed a
few things at the end there:

- misspelled "description" in a test mock
- the server file and both server handlers take the same options, so I
deduped them
- related, I wasn't passing apiRootPath through to the server file
handler
- I incorrectly accessed `.handler` on `apiServerHandler` in
flightcontrol and render
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant