Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fwtools): handle existing resolutions in tarsync #9840

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Jan 17, 2024

Currently there's a @graphql-codegen package in canary that doesn't exist at the published version we have to set a resolution for (see dotansimha/graphql-code-generator#9808). yarn rwfw project:tarsync overwrites the resolutions, so you have to add it back after running the command which is annoying. This just makes it add the tarball resolutions to the existing ones:

  "resolutions": {
    // This is now preserved
    "@graphql-codegen/visitor-plugin-common": "4.0.1",
    "@redwoodjs/fastify-plugin-streaming": "./tarballs/redwoodjs-fastify-plugin-streaming.tgz",
    "@redwoodjs/api": "./tarballs/redwoodjs-api.tgz",
    "@redwoodjs/api-server": "./tarballs/redwoodjs-api-server.tgz",
    // ...
  }

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Jan 17, 2024
@jtoar jtoar added this to the chore milestone Jan 17, 2024
@jtoar jtoar requested a review from Tobbe January 17, 2024 13:29
@jtoar jtoar merged commit c9426e3 into main Jan 17, 2024
38 checks passed
@jtoar jtoar deleted the ds-fw-tools/handle-existing-resolutions-in-tarsync branch January 17, 2024 13:59
dac09 added a commit that referenced this pull request Jan 22, 2024
…edwood into try/setupScenario-multiple-tests

* 'try/setupScenario-multiple-tests' of github.com:dac09/redwood: (235 commits)
  chore(project-config): switch to vitest (#9864)
  chore(ci): Fix CRWA telemetry check (#9865)
  chore(crwa): update e2e test to handle yarn install patch (#9862)
  feat(crwa): Always install using yarn v4 (#9861)
  fix(cli): Skip Studio when running `rw upgrade` (#9860)
  fix(studio): Upgrade to 11.0.1 and enable web-side (#9858)
  feat(server file): add `createServer` (#9845)
  chore(crwa): set `REDWOOD_CI` and `REDWOOD_DISABLE_TELEMETRY` (#9857)
  Fix(crwa): Exit 0 after Quit install (#9856)
  chore(crwa): switch to vitest (#9855)
  chore(api): Switch to use vitest over jest (#9853)
  fix(server): ensure consistency between CLI serve entrypoints regarding help and strict (#9809)
  Improve how the api-server watch command works (#9841)
  docs(typo): correct grammar in realtime docs (#9850)
  Add support for Prisma Bytes and GraphQL scalar Byte (#9847)
  packages/cli: Switch from substr (deprecated) to slice (#9849)
  mapPrismaScalarToPagePropTsType: Fix Decimal test case (#9846)
  chore(build): Avoid prebuilding api side, instead use an esbuild plugin (#9767)
  Fix url query param encoding (#9844)
  chore(fwtools): handle existing resolutions in tarsync (#9840)
  ...
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants