Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the indexed type reference on AvailableRoutes #8918

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Remove the indexed type reference on AvailableRoutes #8918

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad68825
Remove the indexed type reference on AvailableRoutes because referenc…
orta Jul 14, 2023
931c904
Merge branch 'main' into tight_routes
dac09 Jul 28, 2023
9d0cab5
Re-add types we forgot to AuthenticatedRoutes
dac09 Jul 28, 2023
1679035
Re-assign an internal type for generated routes map
dac09 Jul 28, 2023
3e24987
Avoid reassignment to const
dac09 Jul 28, 2023
b2ac401
Clean up, DRY it up
dac09 Jul 28, 2023
db67b43
Merge branch 'main' into tight_routes
dac09 Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/router/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ export * from './route-focus'
export { parseSearch, getRouteRegexAndParams, matchPath } from './util'

/**
* A more specific interface will be generated by
* babel-plugin-redwood-routes-auto-loader when a redwood project is built
* A more specific interface is created in `.redwood/types/includes/web-routerRoutes`
* when the site is built, which will describe all known routes.
*
* @example
* interface AvailableRoutes {
Expand All @@ -32,11 +32,7 @@ export { parseSearch, getRouteRegexAndParams, matchPath } from './util'
* }
*/
// Keep this in index.ts so it can be extended with declaration merging
export interface AvailableRoutes {
[key: string]: (
args?: Record<string | number, string | number | boolean>
) => string
}
export interface AvailableRoutes {}

export { SkipNavLink, SkipNavContent } from '@reach/skip-nav'

Expand Down