Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSC build without user config #8896

Merged
merged 3 commits into from
Jul 13, 2023
Merged

RSC build without user config #8896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f7cd41
RSC build without user config
Tobbe Jul 13, 2023
a71183c
limit code churn
Tobbe Jul 13, 2023
5e5e254
Merge branch 'main' into tobbe-rsc-build-without-user-config
Tobbe Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vite/src/buildRscFeServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const buildRscFeServer = async ({
const { clientEntryFiles, serverEntryFiles } = await rscBuild(viteConfigPath)

const clientBuildOutput = await viteBuild({
configFile: viteConfigPath,
// configFile: viteConfigPath,
root: webSrc,
plugins: [react(), rscIndexPlugin()],
build: {
Expand Down Expand Up @@ -194,7 +194,7 @@ export const buildRscFeServer = async ({
// https://github.com/microsoft/TypeScript/issues/53656 have both landed we
// should try to do this instead:
// const clientBuildManifest: ViteBuildManifest = await import(
// path.join(getPaths().web.dist, 'build-manifest.json'),
// path.join(getPaths().web.dist, 'client-build-manifest.json'),
// { with: { type: 'json' } }
// )
// NOTES:
Expand Down
3 changes: 1 addition & 2 deletions packages/vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ import { getConfig, getPaths } from '@redwoodjs/project-config'
import { handleJsAsJsx } from './vite-plugin-jsx-loader'

/**
* Preconfigured vite plugin, with required config for Redwood apps.
*
* Pre-configured vite plugin, with required config for Redwood apps.
*/
export default function redwoodPluginVite(): PluginOption[] {
const rwPaths = getPaths()
Expand Down