-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint rule: process-env-computed #8612
Merged
Tobbe
merged 25 commits into
redwoodjs:main
from
Tobbe:tobbe-eslint-plugin-process-env-computed
Jun 15, 2023
Merged
ESLint rule: process-env-computed #8612
Tobbe
merged 25 commits into
redwoodjs:main
from
Tobbe:tobbe-eslint-plugin-process-env-computed
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
changed the title
ESLint rule: process env computed
ESLint rule: process-env-computed
Jun 14, 2023
jtoar
reviewed
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tobbe this is great! Did a quick review and left a few comments
…thub.com/Tobbe/redwood into tobbe-eslint-plugin-process-env-computed
jtoar
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite allows
process.env['ENV_VAR']
when running the dev server, but not when building.We want to warn as soon as possible, so I've written an ESLint plugin rule that errors out on the array access syntax
Here's a codemod that does the change for you: #8611
The idea is people run the codemod to fix all existing errors in their projects. And then this lint rule will make sure they don't introduce this error again anywhere