-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Update node version for telemetry check #8004
Conversation
16 replays were recorded for e665451. 16 PassedrequireAuth graphql checks
|
I'm going to enable auto-merge on this without an additional approval given how minor the change is and that it'll be blocking CI on all other PRs until this is corrected. |
@@ -330,7 +330,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, windows-latest] | |||
node-version: [16, 18] | |||
node-version: [16.20.0, 18] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a miss on actions/setup-node
's part. Not sure why 16 doesn't pull down the latest.
Just checked their docs—we could set the "check-latest" option to true:
node-version: [16.20.0, 18] | |
node-version: [16, 18] | |
check-latest: true |
https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#check-latest-version
But maybe it's better to be more exact like you have it here since we support a minimum 16 version? I'll leave it up to you! If we go with 16.20.0
I'll have to change the settings to accept a check passing with that title, which is no big deal. Docs for reference:
"node": ">=16.20 <=18.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed the required check's name for now
* Update ci.yml * Update ci.yml
…te-ssr * 'feat/vite-ssr' of github.com:dac09/redwood: chore(build): Avoid prebuilding api side, instead use an esbuild plugin (redwoodjs#7672) chore(deps): update dependency @clerk/clerk-react to v4.14.2 (redwoodjs#8016) chore(deps): update dependency @azure/msal-browser to v2.35.0 (redwoodjs#8009) chore(deps): update dependency @supabase/supabase-js to v2.14.0 (redwoodjs#8010) fix(deps): update typescript-eslint monorepo to v5.57.1 (redwoodjs#8008) fix(deps): update dependency core-js to v3.30.0 (redwoodjs#8007) chore(deps): update dependency @playwright/test to v1.32.2 (redwoodjs#8005) fix(deps): update dependency @fastify/static to v6.10.0 (redwoodjs#7999) chore(deps): update dependency dependency-cruiser to v12.11.1 (redwoodjs#7998) Update docs to reference creating an ED25519 key instead of RSA (redwoodjs#8013) chore(deps): update dependency @types/react to v18.0.33 (redwoodjs#7996) chore(deps): update dependency @replayio/playwright to v0.3.28 (redwoodjs#8006) chore(deps): update dependency esbuild to v0.17.15 (redwoodjs#7994) chore(deps): update mheap/github-action-required-labels action to v4 (redwoodjs#7997) chore(ci): Update node version for telemetry check (redwoodjs#8004)
Problem
After updating the engine check requirements to a minimum of
16.20
the GitHub ci node version is too low for telemetry checks to run as intended.Changes
Update from
16
to16.20.0
in the node version.