Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): Fix Vite entry point on windows #7554

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Feb 3, 2023

Fix for Vite not loading the app correctly in yarn rw dev on Windows

Should be pulled into 4.1.x RC branch!

Issue originally reported here: https://community.redwoodjs.com/t/guide-experimental-vite-support-in-redwood-v4-1-rc/4466/3

@dac09 dac09 added the release:fix This PR is a fix label Feb 3, 2023
@dac09 dac09 requested a review from jtoar February 3, 2023 11:32
@jtoar jtoar merged commit c6a31f1 into redwoodjs:main Feb 3, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 3, 2023
@dennemark
Copy link
Contributor

This PR leads to issues when reloading, since entry-client.jsx is attached to whole url. http://localhost:8910/my-page/entry-client.jsx net::ERR_ABORTED 404 (Not Found)
It might be enough to add a slash: `<script type="module" src="/entry-client.jsx"></script>
I have tried it on windows in dev mode. Hope it works for others, too.

@jtoar jtoar modified the milestones: next-release, v4.1.0 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants