Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codemod] Handle node versions that don't bundle corepack #4645

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Mar 3, 2022

I added a codemod in #4444 for upgrading projects to yarn 3. But the codemod didn't work for projects on Node.js versions less than v14.19. The codemod handled that by saying upgrade Node first, but there's an alternative to that we prefer: install corepack via npm i -g corepack.

This PR updates the codemod so that it throws a more helpful error message.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Mar 3, 2022
@jtoar jtoar self-assigned this Mar 3, 2022
@jtoar jtoar enabled auto-merge (squash) March 3, 2022 19:44
@jtoar jtoar merged commit 4a5ba3e into main Mar 3, 2022
@jtoar jtoar deleted the ds-handle-corepack-in-upgrade-yarn branch March 3, 2022 19:55
@jtoar jtoar added this to the next-release milestone Mar 3, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v0.48.0 Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

3 participants