Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous i18n dependency from i18n setup #11789

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Dec 22, 2024

I upgraded the i18n-next stack in our Redwood application today and dug a little through the transitive dependencies.

It appears that i18n is not a very actively maintained package that is still in pre-v1.

Neither i18next, nor react-i18next or i18next-browser-languagedetector depend on it.

Hence it can be safely removed tidying up your dependency tree a bit.

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) changesets-ok Override the changesets check labels Dec 22, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Dec 22, 2024
@Tobbe Tobbe merged commit cb7fddb into redwoodjs:main Dec 22, 2024
50 checks passed
@Philzen Philzen deleted the patch-30 branch December 22, 2024 22:23
Philzen added a commit to Philzen/redwood that referenced this pull request Dec 29, 2024
Philzen added a commit to Philzen/redwood that referenced this pull request Dec 30, 2024
Tobbe added a commit that referenced this pull request Jan 16, 2025
@Tobbe Tobbe modified the milestones: next-release-patch, v8.4.3 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants