Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing Guidelines #981

Closed
wants to merge 7 commits into from
Closed

Contributing Guidelines #981

wants to merge 7 commits into from

Conversation

hedgerh
Copy link
Contributor

@hedgerh hedgerh commented Oct 30, 2015

This is a rough first draft of a CONTRIBUTING.md, as per #443.

Still need to describe version, preversion, postversion, and prepublish scripts.

Also not sure what else needs to be covered.

@gaearon
Copy link
Contributor

gaearon commented Oct 31, 2015

Lol, I totally forgot I have these *version scripts.
I don't use them—I bump manually.
Maybe I should.

npm run build
```

To build the lib:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing. “Build the lib” presumes contributor knows what we mean by lib. Better to explain that the build task contains two subtasks: the CommonJS module-per-module build and a UMD build.

@ellbee
Copy link
Contributor

ellbee commented Nov 29, 2015

Ping @hedgerh. This looks great. I'd love to get it finished and merged. No pressure if you are too busy right now—if you like I could take what you've done and carry on from here.

@ellbee
Copy link
Contributor

ellbee commented Dec 3, 2015

We should add a section to this document about style changes and eslint-config-rackt which says basically what @timdorr said in the second paragraph of this comment #1081 (comment).

@hedgerh
Copy link
Contributor Author

hedgerh commented Dec 5, 2015

Sorry for the delay. Just started a new job. I'll make revisions tonight. @ellbee if I don't get it wrapped up tonight, I'd definitely appreciate some help

@ellbee
Copy link
Contributor

ellbee commented Dec 5, 2015

@hedgerh Cool, thanks. No need to apologise, I appreciate the effort you put into this.

@ellbee
Copy link
Contributor

ellbee commented Dec 10, 2015

@hedgerh I've squashed your commits and created a new PR #1124. Thanks again.

@ellbee ellbee closed this Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants