-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing Guidelines #981
Conversation
Lol, I totally forgot I have these |
npm run build | ||
``` | ||
|
||
To build the lib: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is confusing. “Build the lib” presumes contributor knows what we mean by lib
. Better to explain that the build
task contains two subtasks: the CommonJS module-per-module build and a UMD build.
Ping @hedgerh. This looks great. I'd love to get it finished and merged. No pressure if you are too busy right now—if you like I could take what you've done and carry on from here. |
We should add a section to this document about style changes and eslint-config-rackt which says basically what @timdorr said in the second paragraph of this comment #1081 (comment). |
Sorry for the delay. Just started a new job. I'll make revisions tonight. @ellbee if I don't get it wrapped up tonight, I'd definitely appreciate some help |
@hedgerh Cool, thanks. No need to apologise, I appreciate the effort you put into this. |
This is a rough first draft of a
CONTRIBUTING.md
, as per #443.Still need to describe
version
,preversion
,postversion
, andprepublish
scripts.Also not sure what else needs to be covered.